fix: improve DND drag feedback in EditableSchemaForm#8449
Merged
rubenfiszel merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
Three issues fixed: - Dragged element clone was invisible because morphDraggedElementToBeLike ran before the clone was in the DOM, copying 0-height from the uninitialized ResizeTransitionWrapper shadow. Fixed with morphDisabled. - Shadow placeholder was inconsistently hidden because the DND library's inline visibility:hidden was overwritten by RTW's reactive style binding. Fixed with !visible CSS class that overrides inline styles. - Small cursor movements immediately triggered field reordering. Added a 200ms grace period after drag start before processing reorder events. The shadow element now shows a dashed blue drop-target indicator instead of being fully hidden. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying windmill with
|
| Latest commit: |
03ee30b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3a5df891.windmill.pages.dev |
| Branch Preview URL: | https://dnd-drag-feedback-follow.windmill.pages.dev |
Contributor
|
Claude Code is working… I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes drag-and-drop feedback in EditableSchemaForm: the dragged field now visually follows the cursor from the start, shows a dashed blue drop-target placeholder, and doesn't jump positions on small movements.
Changes
morphDisabled: trueto DND config — prevents the library from copying dimensions from an uninitialized ResizeTransitionWrapper shadow (0 height), which made the floating clone invisible!visibleoverrides the library's inlinevisibility: hiddenthat was inconsistently cleared by RTW's reactive style binding)Test plan
Generated with Claude Code